Skip to content

feat: support importOrderImportAttributesKeyword#273

Merged
byara merged 1 commit into
trivago:v5from
chentsulin:feat/support-import-attributes
Dec 3, 2024
Merged

feat: support importOrderImportAttributesKeyword#273
byara merged 1 commit into
trivago:v5from
chentsulin:feat/support-import-attributes

Conversation

@chentsulin
Copy link
Copy Markdown
Contributor

@chentsulin chentsulin commented Dec 12, 2023

Fix #270.
Add an importOrderImportAttributesKeyword option to support three different kinds of syntax.

For example:

  "importOrderImportAttributesKeyword": 'with'

Todo:

Comment thread types/index.d.ts
* "importOrderImportAttributesKeyword": 'with',
* ```
*
* _Default behavior:_ When not specified, @babel/generator will try to match the style in the input code based on the AST shape.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you find this default behavior not to be reliable enough?

@byara byara requested review from ayusharma and byara December 3, 2024 14:48
@byara byara changed the base branch from main to v5 December 3, 2024 14:48
@byara byara force-pushed the feat/support-import-attributes branch from 6c9e134 to b83e56a Compare December 3, 2024 17:00
@byara byara merged commit 3341a50 into trivago:v5 Dec 3, 2024
@byara byara mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package breaks when using import assertions

3 participants